Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ability to NOT enable catalog integration by default #34

Open
ihor-sviziev opened this issue Sep 27, 2023 · 6 comments
Open

No ability to NOT enable catalog integration by default #34

ihor-sviziev opened this issue Sep 27, 2023 · 6 comments

Comments

@ihor-sviziev
Copy link

ihor-sviziev commented Sep 27, 2023

When installing extension and configuring sync, the catalog sync is enabled by default, and even when you don't need it - it starts automatically pushing products to Meta.

It looks like it's caused by

public function enableCatalogSync($commercePartnerIntegrationId, $storeId)
{
if ($commercePartnerIntegrationId) {
$this->fbeHelper->log(sprintf('Catalog sync is enabled for store %s', $storeId));
$this->systemConfig->saveConfig(
SystemConfig::XML_PATH_FACEBOOK_ENABLE_CATALOG_SYNC,
true,
$storeId
);
}
return $this;

and
<event name="facebook_fbe_onboarding_after">
<observer name="facebook_sync_full_catalog" instance="Meta\Catalog\Observer\Facebook\SyncFullCatalog" />
</event>

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

  1. [Screenshots, logs or description]

Actual result (*)

  1. [Screenshots, logs or description]
@ihor-sviziev
Copy link
Author

Fixed by disabling the Meta_Catalog extension in the config.php file, but it's currently impossible to disable it through admin or at least through php bin/magento module:disable Meta_Catalog due to existing dependence from Meta_Sales exntesion.
So far, module is diabled and order sync still works fine

@zlik
Copy link
Contributor

zlik commented Oct 3, 2023

@zlik
Copy link
Contributor

zlik commented Oct 3, 2023

@ihor-sviziev, I believe in the latest version, we always want for products to be synced to Meta because it improves catalog quality and drives ads performance for the seller. If there's an existing feed coming from other sources than our extension, that shouldn't be a problem – we should be able to correctly resolve any product duplicates.

@ihor-sviziev
Copy link
Author

ihor-sviziev commented Oct 6, 2023

@zlik, we don't want to fight with all the integration all at once (potential issues with different prices, different discounts, conflicts with already installed extensions, solving how to manage product descriptions for different languages, etc), so we would like to start with something simple. A simple thing is an XML feed, which we can generate as a static file and update regularly. This definitely won't generate any unexpected load on production, won't cause any exceptions, etc.
So, not having the ability to disable a catalog sync isn't a good thing.

@zlik
Copy link
Contributor

zlik commented Oct 7, 2023

@zlik, we don't want to fight with all the integration all at once (potential issues with different prices, different discounts, conflicts with already installed extensions, solving how to manage product descriptions for different languages, etc), so we would like to start with something simple. A simple thing is an XML feed, which we can generate as a static file and update regularly. This definitely won't generate any unexpected load on production, won't cause any exceptions, etc. So, not having the ability to disable a catalog sync isn't a good thing.

I see your point @ihor-sviziev, makes a lot of sense to me! I'm checking with the team if there's a better way to handle this. We could potentially ask during onboarding whether the seller wants to enable catalog sync or not. Please stay tuned, we should get back to you on this shortly!

@sol-loup
Copy link
Contributor

@ihor-sviziev, this as well as your other issue should be resolvable through the configs we exposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants