Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3236: Change user time to logout #4260

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

PWA-3236: Change user time to logout #4260

wants to merge 5 commits into from

Conversation

glo11372
Copy link
Collaborator

@glo11372 glo11372 commented May 6, 2024 •
edited

Description

1.Inside admin panel set any value of Cookie Lifetime (stores->configuration->general->web->DefaultCookies setting>Cookie Lifetime)
2. Go to your Venia store login with your credentials and wait &check you will be logout as per the cookies lifetime value

Related Issue

Closes #4230

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

1.Try to change admin panel cookies lifetime value and test on frontend
2.If the value is empty it will by default use 3600

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 added the enhancement New feature or request label May 6, 2024
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress May 6, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 6, 2024 •
edited

Fails
🚫

node failed.
🚫

GraphQL queries did not pass. Make sure to execute yarn run validate-queries locally prior to committing.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log



ERROR ON TASK: validateQueries



Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json




  Generated by 🚫 dangerJS against facd23d


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  

  


    

        @glo11372
glo11372




        added
  the 

  version: Patch

  This changeset includes backwards compatible bug fixes.
 label


    May 6, 2024

  










      

  
      



  

  @huykon





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
          huykon
  

      

      

      commented


        May 23, 2024


      
    


  





      


        


  
    

      
          
Hi @glo11372 the mutation generateCustomerToken didn't return cookie_lifetime

so far, why we don't use Customer Token Lifetime in (stores->configuration->services->OAuth->Access Token Expiration>Customer Token Lifetime (hours) ) ?

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
      



  

  @glo11372





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Collaborator


      

  Author


  


  

    

      

      
          glo11372
  

      

      

      commented


        May 23, 2024


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
  
  

      
    
  



    


  





      


        


  
    

      
          


Hi @glo11372 the mutation generateCustomerToken didn't return cookie_lifetime so far, why we don't use Customer Token Lifetime in (stores->configuration->services->OAuth->Access Token Expiration>Customer Token Lifetime (hours) ) ?




Hi @huykon


    

  1. Yes you are right we can use  ‘Customer Token Lifetime’  here and convert that hour in seconds and pass it to PWA.
    2. 

  2. Added  optional value (Customer Token Lifetime’) in generateCustomerToken which can be  used in pwa
    3. 


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
        





      

  
          







      

  
        





      

  
        





      

  
          

  

    
  

  


    

        @m2-community-project
m2-community-project
bot



      
  moved this from Review in Progress
  to Reviewer Approved
  in Pull Request Progress


    May 24, 2024

  





  











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
    @glo82145
  
    glo82145



          
            
              
            
          
          glo82145 approved these changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
    @glo82145
  
    glo82145
    

      








      


  


  

    Labels
  



    

      

    enhancement

  New feature or request
  

    pkg:peregrine

  

    pkg:venia-ui

  

    Progress: approved

  

    version: Patch

  This changeset includes backwards compatible bug fixes.








      

  

    

        

    Projects
  


        




        
  

    

        
    

    

      
        Pull Request Progress

        

          Reviewer Approved
        

    

  






  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.


  
    
            
        [feature]: Change user time to logout





    
  




        
      

    

  
      

  

    

      4 participants
    

    

        
          @glo11372 
        
          @pwa-studio-bot 
        
          @huykon 
        
          @glo82145