Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort / orderBy #173

Open
magicdawn opened this issue Mar 12, 2024 · 4 comments
Open

sort / orderBy #173

magicdawn opened this issue Mar 12, 2024 · 4 comments

Comments

@magicdawn
Copy link
Owner

No description provided.

@magicdawn
Copy link
Owner Author

lodash.orderBy

function orderBy(collection, columns, order){
}
  • order参数只支持 asc | desc, 不支持自定义 comparer

lodash/lodash#3764

@magicdawn
Copy link
Owner Author

magicdawn commented Mar 12, 2024

@magicdawn
Copy link
Owner Author

natural-orderby

API

API 用起来和 _.orderBy 一样, 但内部逻辑太复杂, 比如

  • 它可以 sort ip 192.168.0.1 < 192.168.0.2
  • string 形式的日期, 会 parseDate

做的事情太多可能不需要, 性能可能会有问题

@magicdawn
Copy link
Owner Author

magicdawn commented Mar 12, 2024

fast-sort

API 设计的有点不合理.

比如看下面这个场景

    const listSorted = sort(list).by([
      { desc: (it) => (it.has_update ? 1 : 0) },
      { asc: (it) => it.uname, 
        comparer: (a, b) => mapName(a).localeCompare(mapName(b), 'zh-CN') },
    ])
  • 使用 desc, 'asc' 作为 key
  • desc | asc | comparer-fn 只是一种排序依据, 但 fn 没法作为 key 输入

改为

type OrderBy<Item> = {
  column: string | ((it: Item) => string | number);
  order: 'asc' | 'desc' | ((a: unknown, b: unknown) => number);
}[]

使用 compare-fn 的时候, 需要 desc 可以 * -1 即可


封装了更像 _.orderBy 的 wrapper

import { sort } from 'fast-sort'

type OrderBy<T> = {
  column: keyof T | ((it: T) => any)
  order: 'asc' | 'desc' | ((a: any, b: any) => number)
}

export function fastOrderBy<T>(
  list: T[],
  columns: OrderBy<T>['column'][],
  orders: OrderBy<T>['order'][],
) {
  if (columns.length !== orders.length) {
    throw new Error('columns & orders length not match')
  }

  const _by = columns.map((column, index) => {
    const order = orders[index]
    if (order === 'asc') return { asc: column }
    else if (order === 'desc') return { desc: column }
    return {
      asc: column,
      comparer: order,
    }
  })

  return sort(list).by(_by)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant