Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource version of functions for setting attributes #34

Open
mahozad opened this issue Jul 9, 2021 · 0 comments
Open

Add resource version of functions for setting attributes #34

mahozad opened this issue Jul 9, 2021 · 0 comments
Assignees
Labels
enhancement Improving an existing feature
Projects

Comments

@mahozad
Copy link
Owner

mahozad commented Jul 9, 2021

In addition to a direct method for updating a property (like chart.setColor(color: Int)), provide a resource version of the method that takes a resource and resolves the value automatically (like chart.setColor(R.color.myColor)) for each property.

This is something practiced in Android Material components. See this for an example.

Also, add separate properties to modify a dimension in sp or dp.
For example, legendSize, legendSizeSp.

@mahozad mahozad added the enhancement Improving an existing feature label Jul 9, 2021
@mahozad mahozad self-assigned this Jul 9, 2021
@mahozad mahozad added this to To do in Roadmap via automation Jul 9, 2021
@mahozad mahozad moved this from To do to In progress in Roadmap Aug 2, 2021
@mahozad mahozad changed the title Add resource version of functions for settings attributes Add resource version of functions for setting attributes Aug 3, 2021
@mahozad mahozad added this to the v0.6.0 milestone Aug 21, 2021
@mahozad mahozad removed this from the v0.6.0 milestone May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
Roadmap
  
In progress
Development

No branches or pull requests

1 participant