Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right click for navigation options (back / forward / reload) #597

Closed
calumcraig opened this issue Feb 19, 2019 · 4 comments · Fixed by #713
Closed

Right click for navigation options (back / forward / reload) #597

calumcraig opened this issue Feb 19, 2019 · 4 comments · Fixed by #713
Labels
browser-missing-feature v0.14.0
Projects
Future Enhancements

Comments

@calumcraig
Copy link

calumcraig commented Feb 19, 2019 •
edited

Feature request

In Firefox and Chrome, right mouse click gives a context menu which includes the navigation options of back, forward and reload:
Chrome:
image
Firefox:
image
Currently the only right click option in SAFE Browser is "Inspect element" - can navigation options (which exist as buttons / menu items) be added to the right click menu?
@calumcraig calumcraig created this issue from a note in Future Enhancements (Needs triage) Feb 19, 2019
@joshuef joshuef moved this from Needs triage to High priority in Future Enhancements Feb 26, 2019
@hunterlester hunterlester moved this from High priority to In Progress in Future Enhancements Apr 15, 2019
Future Enhancements automation moved this from In Progress to Ready For QA Apr 15, 2019
@hunterlester hunterlester reopened this Apr 15, 2019
Future Enhancements automation moved this from Ready For QA to In Progress Apr 15, 2019
@hunterlester hunterlester self-assigned this Apr 15, 2019
@hunterlester
Copy link
Contributor

hunterlester commented Apr 15, 2019 •
edited

Recommending that this task not be completed until we complete migration from webview's to BrowserView's as view architecture will change drastically.
Reference #651

However...the behavior defined in Tab.tsx is easy to move over to BrowserView.

@hunterlester hunterlester removed their assignment Apr 15, 2019
@hunterlester hunterlester moved this from In Progress to High priority in Future Enhancements Apr 15, 2019
@hunterlester hunterlester moved this from High priority to In Progress in Future Enhancements Apr 15, 2019
@hunterlester hunterlester moved this from In Progress to High priority in Future Enhancements Apr 16, 2019
@joshuef
Copy link
Collaborator

joshuef commented Apr 29, 2019

As I'm not sure about Browser View's prospects re: zindexing etc, I'm gonna fire into this as it's largely just adding some menu options.

@joshuef joshuef moved this from High priority to In Progress in Future Enhancements Apr 29, 2019
@joshuef
Copy link
Collaborator

joshuef commented Apr 29, 2019

Changes made and these have been added over here: https://github.com/joshuef/safe_browser/tree/FeatContextMenu

But waiting on an updated electron-context-menu (sindresorhus/electron-context-menu#67)

@joshuef joshuef moved this from In Progress to Needs review in Future Enhancements May 1, 2019
@joshuef joshuef removed the blocked label May 1, 2019
@joshuef joshuef mentioned this issue May 1, 2019
Merged
joshuef added a commit to joshuef/sn_browser that referenced this issue May 1, 2019
@joshuef
feat(context): Add more context menus.
86938bb 
Fixes maidsafe#597
Future Enhancements automation moved this from Needs review to Ready For QA May 1, 2019
bochaco pushed a commit that referenced this issue May 1, 2019
@joshuef @bochaco
feat(context): Add more context menus.
87741c5 
Fixes #597
@safesurfer
Copy link
Contributor

I can now see the menu options in the right-click context menu. (Back, Forward, Reload, Open New Tab, etc.)

@safesurfer safesurfer moved this from Ready For QA to Done in Future Enhancements Jun 3, 2019
manavbp pushed a commit that referenced this issue Jun 27, 2019
@joshuef @manavbp
feat(context): Add more context menus.
e553646 
Fixes #597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-missing-feature v0.14.0
Projects
Future Enhancements
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(context): Add more context menus. joshuef/sn_browser
4 participants
@joshuef @hunterlester @safesurfer @calumcraig