Service Workers are not supported

[happybeing]

An app which works in mock fails when the origin is a safe:// URI. Here's the error message:

serviceWorker.ts:97 Error during service worker registration: DOMException: Failed to register a ServiceWorker: The URL protocol of the current origin ('safe://solid-filemanager') is not supported

This may be an electron issue, see: electron/electron#2831

You can reproduce the error by choosing a WebID, visiting safe://solid-filemanager, waiting for the app to load and a popup to appear, and then clicking Login. The code is at https://github.com/theWebalyst/solid-filemanager/blob/master/src/serviceWorker.ts

I'm using SB v0.14.1 on Ubuntu 18.10.

Any short term fudge I could try here?

[joshuef]

Reads like we'll just need to update the options we provide to https://electronjs.org/docs/api/protocol#protocolregisterschemesasprivilegedcustomschemes

That should work. And if it does, I don't have any objection to getting this merged in!

[happybeing]

Hi Josh,

I tried

protocol.registerSchemesAsPrivileged( [ {scheme: PROTOCOLS.SAFE, privileges: { allowServiceWorkers: true } } ] );

But this API doesn't exist pre v5 and SB is using v4. So I went looking for docs on registerServiceWorkerSchemes(). I didn't find the API docs, but the following suggests it doesn't work yet anyway so this may not be fixable:

See electron/electron#9663 (comment)

[joshuef]

Aha. Righto. Okay, well the upgrade path to e5/6 + will involve some FFI changes to safe_app nodejs. That's not a prio right now with the new APIs we're working on. But they'll be built for N-API which is good to go w/ newer electron versions.

So there's not much to be done right now I think, sorry @theWebalyst

[happybeing]

No problem. Thanks for looking.

[johannesjo]

@joshuef any update on this?

There are many open issues regarding this in all sorts of different shades. Currently it seems that there is no sensible way to service workers work when serving from the local file system.

electron/electron#9705
electron/electron#2831
electron/electron#10146
electron/electron#14885
electron/electron#20248

[marciot]

I'm curious what is the latest status on this. Is it correct to assume that at this point, service workers cannot be used in Electron apps that run from local files?

[happybeing]

Looks like a fix for this has been merged!

electron/electron#20248 (reference)

[joshuef]

sorry @johannesjo for the radio silence. browser has been fairly backburner lately (and then i've been on paternity).

Looks like this'll get solved when we're able to upgrade to latest electron if that fix sorts things. Browser is still reasonably backburner though atm.