Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom DKIM selector #2349

Closed
wants to merge 4 commits into from
Closed

Conversation

bilogic
Copy link
Contributor

@bilogic bilogic commented Jan 5, 2024

Fixes #2348

Allows us to avoid a DKIM TXT record clash when in use with other sending servers. Thank you.

setup/migrate.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kiekerjan kiekerjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work.

@bilogic
Copy link
Contributor Author

bilogic commented Jan 24, 2024

@JoshData is this ok?

@JoshData
Copy link
Member

I would like to avoid using /etc/mailinabox.conf for new settings and put the settings in $STORAGE_ROOT, e.g. $STORAGE_ROOT/mail/dkim/selector.txt.

/etc/mailinabox.conf isn't included in backups and was meant for really low-level settings needed to do automated installs like the IP address.

@bilogic
Copy link
Contributor Author

bilogic commented Mar 11, 2024

ok, let me take a look as it has been a while :)

@bilogic
Copy link
Contributor Author

bilogic commented Mar 17, 2024

@JoshData

I had a look.

Using $STORAGE_ROOT/mail/dkim/selector.txt would scatter configuration over alot of files. e.g. I have another PR trying to adjust TTL

How about $STORAGE_ROOT/mailinabox.conf, with it taking priority over /etc/mailinabox.conf?

@bilogic
Copy link
Contributor Author

bilogic commented Apr 21, 2024

@JoshData

How about $STORAGE_ROOT/mailinabox.conf, with it taking priority over /etc/mailinabox.conf?

I'm of the view that this is the best way forward and have filed a PR to demonstrate it.

This would mean, we still have to add all settings into /etc/mailinabox.conf, but they can be optionally overridden and backed up by $STORAGE_ROOT/mailinabox.conf

Does this address all your concerns? Thank you!

@bilogic
Copy link
Contributor Author

bilogic commented Apr 21, 2024

also brought this PR up to v68, ready to be merged

@bilogic bilogic closed this Apr 21, 2024
@bilogic bilogic deleted the dkim-custom-selector branch April 21, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom DKIM selector
3 participants