Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with assert.dom(this.element) types with latest Ember and QUnit #1622

Open
knownasilya opened this issue Jun 18, 2022 · 3 comments
Open

Comments

@knownasilya
Copy link

knownasilya commented Jun 18, 2022

Getting type error like:

Argument of type 'Element | Document' is not assignable to parameter of type 'string | Element | null | undefined'.

The type of this.element is

TestContext.element: Element | Document

but assert.dom doesn't expect a Document.

"ember-source": "~4.5.0",
"@types/qunit": "^2.19.0",
"ember-qunit": "^5.1.5",
"qunit": "^2.19.1",
"qunit-dom": "^2.0.0",

@Turbo87
Copy link
Collaborator

Turbo87 commented Jun 18, 2022

Yes, we intentionally do not accept document because it is missing some APIs

@knownasilya
Copy link
Author

Is this an issue with ember-qunit? cc @rwjblue

@raido
Copy link

raido commented Nov 3, 2023

This is still an issue. Any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants