Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it makes sense to add vanilla / vanillajs to this project's tags? #2059

Open
NullVoxPopuli opened this issue Oct 8, 2023 · 1 comment

Comments

@NullVoxPopuli
Copy link
Contributor

Just looking here:
image

the first tags are ember/emberjs.

But with the v3 release candidate (and higher), ember is no longer really relevant to use qunit-dom (it doesn't need to be).

support for ember isn't even really a thing.
(aside from this id here:

: () => document.querySelector('#ember-testing');
-- but that could probably be made configurable )

qunit-dom now works with anything, in any environment ✨

(JSBin example here: https://jsbin.com/fipayiy/edit?html,output )

@BobrImperator
Copy link
Contributor

I think it makes sense, in fact when used as a module and not iffe, a getRootElement function can be provided already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants