Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: baseURL defaults when configured as object #877

Merged
merged 1 commit into from Jan 16, 2023

Conversation

cossssmin
Copy link
Member

This PR fixes an issue with baseURL defaults when it is configured as an object.

Specifically, in this case the url was not being appended to <style> tags or inline CSS, you had to enable them manually, i.e.:

baseURL: {
  url: 'https://example.com/images/',
  tags: ['img', 'source'],
  inlineCss: true,
  styleTag: true,
},

Now you can just do this and it will work:

baseURL: {
  url: 'https://example.com/images/',
  tags: ['img', 'source']
},

@cossssmin cossssmin merged commit 4fab6e3 into next Jan 16, 2023
@cossssmin cossssmin deleted the fix/baseURL-defaults branch January 16, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant