Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

Avoid FlowCollectionDirector to reset sectionInset, minimumInteritemSpacing and minimumLineSpacing of UIColletionViewLayout #24

Open
wow-such-amazing opened this issue Nov 12, 2018 · 3 comments
Open

Avoid FlowCollectionDirector to reset sectionInset, minimumInteritemSpacing and minimumLineSpacing of UIColletionViewLayout #24

wow-such-amazing opened this issue Nov 12, 2018 · 3 comments
Assignees
@malcommac
Labels
bug Something isn't working
Milestone
0.9.0

Comments

@wow-such-amazing
Copy link

wow-such-amazing commented Nov 12, 2018 •
edited

Why do you clean some layout properties after initialising FlowCollectionDirector?

		self.layout?.sectionInset = .zero
		self.layout?.minimumInteritemSpacing = CGFloat.leastNormalMagnitude
		self.layout?.minimumLineSpacing = 0
@wow-such-amazing
Copy link
Author

Can't this be a problem? Because if I initialise UICollectionView from code, then I need to pass layout into its initialiser. And before doing that I may want to configure somehow my layout. But later when I initialise an adapter some my changes may be overridden

@wow-such-amazing wow-such-amazing changed the title Initializing FlowCollectionDirector Question: Initialising FlowCollectionDirector Nov 13, 2018
@malcommac malcommac changed the title Question: Initialising FlowCollectionDirector Avoid FlowCollectionDirector to reset sectionInset, minimumInteritemSpacing and minimumLineSpacing of UIColletionViewLayout Nov 20, 2018
malcommac added a commit that referenced this issue Nov 20, 2018
@malcommac
#24 Fixed reset of UICollectionViewLayout's props
4e35058 
Fixed an issue which reset sectionInset, minimumInteritemSpacing and minimumLineSpacing of UIColletionViewLayout after initialization of the FlowCollectionDirector
@malcommac
Copy link
Owner

Absolutely true, it was added for test and never removed. My fault, fixed for the next release.

@malcommac malcommac added this to the 0.9.0 milestone Nov 20, 2018
@malcommac malcommac self-assigned this Nov 20, 2018
@malcommac malcommac added the bug Something isn't working label Nov 20, 2018
@wow-such-amazing
Copy link
Author

Thanks 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@malcommac malcommac

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@malcommac @wow-such-amazing