Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override any manualChunks from the user config #58

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

SIGSTACKFAULT
Copy link
Contributor

low effort solution, but works. fixes #57.

Verified

This commit was signed with the committer’s verified signature.
low effort solution, but works
mammadataei
mammadataei previously approved these changes Jul 4, 2023
@mammadataei
Copy link
Owner

@SIGSTACKFAULT Thanks for your contribution.

Typescript is not happy with the false value. Can you please check whether using undefined fixes the issue?

@mammadataei mammadataei merged commit c38600e into mammadataei:main Jul 5, 2023
@SIGSTACKFAULT
Copy link
Contributor Author

SIGSTACKFAULT commented Jul 5, 2023

...and it doesn't actually work when it's undefined. only false seems to work. I figured anything vaguely falsey would work.

@SIGSTACKFAULT
Copy link
Contributor Author

SIGSTACKFAULT commented Jul 5, 2023

{} and () => void don't work either because they exist for the purpose of the checks despite not doing anything

@mammadataei
Copy link
Owner

Oh, I thought it worked with undefined. If it only works with false, then it might be a typing issue. I will open a new issue and create a new pull request to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants