Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Support protobuf Python library v5 #1422

Open
poodlewars opened this issue Mar 14, 2024 · 4 comments
Open

maint: Support protobuf Python library v5 #1422

poodlewars opened this issue Mar 14, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@poodlewars
Copy link
Collaborator

poodlewars commented Mar 14, 2024

Is your feature request related to a problem? Please describe.
Protobuf has released version 5 but we only support version 3 and 4. PR #1421 has constrained protobuf version for now.

We should relax this constraint that we are imposing on user's envs.

Our proto handling is quite complex - we compile Python proto stubs suitable for both proto 3 and proto 4 and choose which a user will "see" at runtime based on their installed proto version.

The solution should consider both wheels and Conda builds.

@poodlewars poodlewars added the enhancement New feature or request label Mar 14, 2024
@jjerphan
Copy link
Collaborator

Currently ArcticDB's conda packages are built for:

protobuf 5 has not yet been published on conda-forge. conda-forge/libprotobuf-feedstock#213 is the first PR to start this work.

We might need to define a build variant for protobuf 3, 4, and 5 once this last version is supported.

@jjerphan
Copy link
Collaborator

jjerphan commented Apr 3, 2024

Related grpc/grpc#36142.

@rhoens
Copy link

rhoens commented May 31, 2024

Hi, any movement on this? Just curious if there's a timeline

@jjerphan
Copy link
Collaborator

jjerphan commented Jun 3, 2024

Likely addressable for conda-forge's builds once conda-forge/protobuf-feedstock#216 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants