Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: implement Gimphash calculation #16

Open
Neo23x0 opened this issue Jan 26, 2023 · 1 comment
Open

Feature request: implement Gimphash calculation #16

Neo23x0 opened this issue Jan 26, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Neo23x0
Copy link

Neo23x0 commented Jan 26, 2023

https://github.com/NextronSystems/gimphash

@stevemk14ebr
Copy link
Collaborator

I've been meaning to evaluate this computation for a while now. It's something I'd like to include for sure. Though some concerns I need to vet personally first before I implement this:

  • How stable is it per compilation of the same source/compiler, what about including changes to source, what breaks it?
  • How stable is it across go versions? The runtime has evolved significantly over time, should there be a cutoff version, a generic version, or a different computation per version?
  • Do other rules need to be included? It's not clear to me if ignoring internal/ is the best as many go applications include real application logic under internal paths. Similarly with vendor, it may be useful to include that, what are the tradeoffs there?
    • Are the standard library exclusions listed complete, go. and type. intuitively seem to make sense off hand, are there others? Have they changed over time?

I do plan on looking into these, if you have any insight it would help move this along.

@stevemk14ebr stevemk14ebr added the enhancement New feature or request label Jan 26, 2023
@williballenthin williballenthin added the good first issue Good for newcomers label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants