Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flag to skip extracting functions #49

Open
pombredanne opened this issue Jan 30, 2024 · 1 comment
Open

Add command line flag to skip extracting functions #49

pombredanne opened this issue Jan 30, 2024 · 1 comment

Comments

@pombredanne
Copy link

When I analyse Go binaries, I often want to have a quick first look at the buildinfo and files without looking at all the function details.
I would awesome to have a command line flag that would skip collecting the function details, basically a conditional on this

GoReSym/main.go

Line 289 in d75fbb4

for _, elem := range finalTab.ParsedPclntab.Funcs {
that would be true by default (so that the behavior is not changed) and the CLI flag would skip/exclude the UserFunctions and StdFunctions sections.

Can I interest you in a patch for this? This would be a very simple update.

@stevemk14ebr
Copy link
Collaborator

A patch like this would be fine, as long as it default to true and doesn't interfere with the actual symbol recovery logic. The proposed change here is how I would do it, the recovery still needs to occur to ensure the correct pclntab candidate is chosen, but then we can ignore displaying that info depending on the provided flag.

I say go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants