Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android support? #5

Open
Hatzen opened this issue Sep 1, 2020 · 3 comments
Open

Android support? #5

Hatzen opened this issue Sep 1, 2020 · 3 comments

Comments

@Hatzen
Copy link

Hatzen commented Sep 1, 2020

Would be useful for ronmamo/reflections#127

@manosbatsis
Copy link
Owner

@Hatzen thanks for opening an issue. Haven't done any android work so can't really tell, but see my comment in #4 as it might be relevant. If you find a way to get this working please let me know or add an MR to update the docs, cheers.

@Hatzen
Copy link
Author

Hatzen commented Sep 7, 2020

Thanks for your fast response. I could not make it to find a way to hook into the necessary steps jar or classes as you mentioned it is not possible for gradle to apply both plugins.
Because lack of time i wont dig deeper into it, i m sorry

@manosbatsis
Copy link
Owner

You probably have equivalent tasks in android builds. In short the plugin should run after compilation and before packaging. You can also try manually running tasks in the right order before automating their order.\

FYIW i'd probably update ReflectionsMetadataEmbeddingTask.resolveOutputDirectory here try remove the java specific calls i.e. getJava(). and make the plugin more lax. Perhaps giving priority to explicit config params for targeting input/output directories.

Trivial really. I'd try to fix for android users if someone added a test for it.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants