Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with recent Sphinx versions (above 5.1.1) #34584

Closed
thomashampson opened this issue Oct 20, 2022 · 4 comments · Fixed by #35928
Closed

Issues with recent Sphinx versions (above 5.1.1) #34584

thomashampson opened this issue Oct 20, 2022 · 4 comments · Fixed by #35928
Assignees
@jclarkeSTFC
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS

Comments

@thomashampson
Copy link
Contributor

Describe the bug

  • Saving/referencing math images files in the wrong place
  • Website search

To Reproduce
Remove the 5.1.1 sphinx pin and build the docs package (5.3.2 is definitely not working).

Expected behavior

  • Latex math should render correctly in our documentaion
  • Search should work on our websites

Screenshots

Platform/Version (please complete the following information):

  • OS: [e.g. Windows, RHEL 7, Ubuntu, macOS]
  • OS Version:
  • Mantid Version [e.g. 6.0.0]

Additional context
@thomashampson thomashampson added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Oct 20, 2022
sf1919 added a commit that referenced this issue Oct 21, 2022
@sf1919
Update developer ymls for sphinx bootstrap theme
68c6ee3 
- this is a part fix towards resolving #34584
@sf1919 sf1919 mentioned this issue Oct 21, 2022
Merged
@sf1919 sf1919 self-assigned this Oct 26, 2022
@sf1919
Copy link
Contributor

sf1919 commented Nov 7, 2022

Waiting for v6 of Sphinx to be released before trying to remove the pin - https://www.sphinx-doc.org/en/master/changes.html

@sf1919
Copy link
Contributor

sf1919 commented Nov 28, 2022

Looks like the earliest v6 will be released is 01/12/22 - sphinx-doc/sphinx#10920

@sf1919 sf1919 mentioned this issue Feb 16, 2023
Closed
@sf1919
Copy link
Contributor

sf1919 commented Feb 16, 2023

Requires pygments to be >=2.12, but this can only be achieved if cppcheck is v2.8 or higher.

@sf1919 sf1919 removed their assignment Feb 24, 2023
@sf1919
Copy link
Contributor

sf1919 commented Jul 14, 2023

Blocked by #33510

@jclarkeSTFC jclarkeSTFC mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jclarkeSTFC jclarkeSTFC

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
No open projects
Release 6.6 ISIS Core
Status: Done
Release 6.7 ISIS Core
Status: Done
Release 6.8 ISIS Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin sphinx and pygments mantidproject/mantid
3 participants
@thomashampson @sf1919 @jclarkeSTFC