Error from selecting curves in plot options #37380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiMacielPereira
added
ISIS Team: Core
GuiMacielPereira
changed the title
jhaigh0
previously requested changes
May 16, 2024
cailafinn
requested changes
May 17, 2024
|
Added unit test, checked that it failed when using previous code. Interestingly, this issue only arises if the |
cailafinn
approved these changes
May 20, 2024
There was a problem hiding this comment.
New test looks good, code looks good, working well functionally. Nice work.
Incidentally, the cause of the extra lines is due to the error bar caps. They're represented under the hood in matplotlib by two additional sets of "lines" (ax.get_lines()) without lines between the data points but with the horizontal line markers to represent the caps. This is why the index was ending up all wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fixes #37358
To test:
Follow instructions on #37358 and check that no error is thrown
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.