Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect extents passed to BinMD from sliceviewer when first change slicepoint by small increment #37385

Open
RichardWaiteSTFC opened this issue May 16, 2024 · 0 comments
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone

Comments

@RichardWaiteSTFC
Copy link
Contributor

Describe the bug

Incorrect extents passed to BinMD from sliceviewer when first change slicepoint by small increment - it looks like BinMD is not called?

To Reproduce

# (1) Create workspace
ws_3D = CreateMDWorkspace(Dimensions='3', Extents='-1,1,-1,1,-1,1',
                          Names='H,K,L', Units='r.l.u.,r.l.u.,r.l.u.',
                          Frames='HKL,HKL,HKL', SplitInto='2', SplitThreshold='50')  # enabled!
                          
# (2) open sliceviewer

# (3) use the spinbox to set slicepoint (along L) to 0.01

# (4) run this code to print the integration limits

ws_mdhisto = mtd[ws_3D.name() + "_svrebinned"]
alg = ws_mdhisto.getHistory().lastAlgorithm()
limits = [float(lim) for lim in alg.getPropertyValue("OutputExtents").split(",")[-2:]]
print("slicepoint = ", np.mean(limits))
print("integration limits = ", limits)

# slicepoint =  0.0
# integration limits =  [-0.05, 0.05]

Expected behavior

Should print

# slicepoint =  0.01
# integration limits =  [-0.04, 0.06]

Platform/Version (please complete the following information):

  • OS: IDAaaS
  • Mantid Version 6.9.20240514.1920 (manual testing) - but present in v6.9

Additional context
Found during core testing #37325

@RichardWaiteSTFC RichardWaiteSTFC added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels May 16, 2024
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.11 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: No status
Status: Backlog
Development

No branches or pull requests

1 participant