Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Muon error when switching to TF Asymmetry fitting #37395

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented May 17, 2024

Description of work

This PR fixes a bug on the Muon Analysis interface when switching between normal fitting mode and TF Asymmetry fitting. The solution was to check if the tf asymmetry fit function can be parsed before attempting to get individual functions from its structure.

Fixes #37392

To test:

  1. Open Muon Analysis interface
  2. Select MUSR instrument
  3. Load 62260
  4. Go to Fitting tab
  5. Right click and add function GausOsc in the function browser
  6. Tick Simultaneous fit over
  7. Change fitting mode from "Normal" to "TF Asymmetry"
  8. There should be no error!

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin changed the base branch from main to release-next May 17, 2024 16:39
@robertapplin robertapplin added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Muon Issues and pull requests related to muons Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels May 17, 2024
@robertapplin robertapplin added this to the Release 6.10 milestone May 17, 2024
@robertapplin robertapplin marked this pull request as ready for review May 17, 2024 16:42
@adriazalvarez adriazalvarez self-assigned this May 20, 2024
Copy link
Contributor

@adriazalvarez adriazalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed instructions: No error message. Thanks for adding the test.

@SilkeSchomann SilkeSchomann merged commit 706d20d into mantidproject:release-next May 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Muon Issues and pull requests related to muons
Projects
Status: Waiting response
Development

Successfully merging this pull request may close these issues.

Error in muon analysis window
3 participants