Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppShell Navbar footer hidden for mobile users with address bar on top #1171

Closed
sunneydev opened this issue Apr 3, 2022 · 5 comments
Closed
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@sunneydev
Copy link
Contributor

sunneydev commented Apr 3, 2022

What package has an issue

@mantine/core

Describe the bug

As mobile browsers implement vh units as the height of the screen the bottom part of the Navbar is not visible unless you manually scroll.

Footer not visible

photo_2022-04-03_08-59-45

Footer visible after scrolling

photo_2022-04-03_08-59-45--2-

unknown

In which browser did the problem occur

Any mobile browser with address bar on top

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/beautiful-water-4ipk7d

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

credits to @mattrunyon

Adding sx={{ bottom: 0, height: "auto" }} to Navbar

@sunneydev sunneydev added the bug label Apr 3, 2022
@rtivital
Copy link
Member

rtivital commented Apr 3, 2022

Thanks for reporting and investigation

@TobiasHansen
Copy link

Also getting this error, let me know if more information is needed.

@rayhk6
Copy link

rayhk6 commented Jul 15, 2022

Thanks for the temporary solution.

@IAFahim
Copy link

IAFahim commented Jul 25, 2022

I have figured out if you add a bottom padding of
paddingBottom: props.theme.spacing.xl it goes away
GitHub link

@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed bug labels Aug 11, 2022
@rtivital
Copy link
Member

Fixed in 5.1.4, Navbar now has bottom: 0 css property, we cannot set height to auto though as there are header and footer height dependencies in css variables. Height can be set with corresponding prop: <Navbar height="auto" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

5 participants