Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert, CloseButton won't show if title is not provided #1348

Closed
yudatadei opened this issue Apr 28, 2022 · 2 comments
Closed

Alert, CloseButton won't show if title is not provided #1348

yudatadei opened this issue Apr 28, 2022 · 2 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@yudatadei
Copy link

{title && (
<div className={classes.title}>
<span id={titleId} className={classes.label}>
{title}
</span>
{withCloseButton && (
<CloseButton
className={classes.closeButton}
onClick={() => onClose?.()}
variant="transparent"
size={16}
iconSize={16}
aria-label={closeButtonLabel}
/>
)}
</div>
)}

@PrathameshAshra
Copy link

if we apply && with span instead of the whole wrapper, we can see the close button even if the title isn't provided.
Can I take this ?

@rtivital
Copy link
Member

Fixed in 5.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

3 participants