Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slide-left transition looks off on modal with size set #1753

Closed
emi2k01 opened this issue Jul 8, 2022 · 3 comments
Closed

slide-left transition looks off on modal with size set #1753

emi2k01 opened this issue Jul 8, 2022 · 3 comments

Comments

@emi2k01
Copy link

emi2k01 commented Jul 8, 2022

What package has an issue

@mantine/core

Describe the bug

If you set size to a big value (~900) in a Modal, the transition slide-left looks off when the modal is opened.

The transitionDuration is to make the problem more apparent but it still looks off without it.

In which browser did the problem occur

Chrome, Firefox

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/mantine-playground-forked-ktf2rw?file=/src/App.tsx

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Sorry, unfortunately I have no experience with mantine's codebase but since I'll start using this library for the months to come, I'd like to learn what I can. If someone has a clue to what's wrong, I'm willing to look into it.

@emi2k01 emi2k01 added the bug label Jul 8, 2022
@emi2k01
Copy link
Author

emi2k01 commented Jul 8, 2022

Using withCloseButton={false} seems to make it look OK. I updated the codesandbox to show both behaviors

@emi2k01
Copy link
Author

emi2k01 commented Jul 8, 2022

Using a smaller width (~600px) seems to make it look ok too, though I don't know why.

If I use 1000px, it looks wrong even though I'm trying it in a big enough viewport.

@rtivital
Copy link
Member

rtivital commented Sep 8, 2022

@rtivital rtivital closed this as completed Sep 8, 2022
@rtivital rtivital removed the help wanted Contributions from community are welcome label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants