Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mantine-core's Table verticalSpacing non-operational if there's a global spacing theme #1832

Closed
aready87 opened this issue Jul 22, 2022 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@aready87
Copy link
Contributor

What package has an issue

@mantine/core

Describe the bug

If there is a global theme for spacing, Table component's verticalSpacing no longer applies, UNLESS horizontalSpacing is assigned a value other than "xs". If horizontalSpacing is assigned a value besides "xs", verticalSpacing overrides the global theme (as it should).

Expectation: verticalSpacing value should apply override the global theme spacing even without horizontalSpacing is applied.

In which browser did the problem occur

Chrome and Firefox

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/elastic-wind-t35912

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

No response

@aready87 aready87 added the bug label Jul 22, 2022
@rtivital rtivital added help wanted Contributions from community are welcome and removed bug labels Aug 5, 2022
@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed help wanted Contributions from community are welcome labels Aug 13, 2022
rtivital added a commit that referenced this issue Aug 13, 2022
@rtivital
Copy link
Member

Fixed in 5.1.5, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants