Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Spoiler: Fix Spoiler inside Accordion #2037

Merged
merged 25 commits into from Aug 8, 2022

Conversation

wes337
Copy link
Contributor

@wes337 wes337 commented Aug 7, 2022

Now uses the useElementSize hook to calculate the spoiler state. This fixes a bug where the height was always 0 when the Spoiler was used inside an Accordion component.

Resolves #1811

@wes337 wes337 changed the title [@mantine/core] Spoiler: useElementSize hook to calculate spoiler state [@mantine/core] Spoiler: Fix Spoiler inside Accordion Aug 8, 2022
@rtivital rtivital merged commit 1a61cfc into mantinedev:master Aug 8, 2022
@rtivital
Copy link
Member

rtivital commented Aug 8, 2022

Works great, thanks!

@wes337 wes337 deleted the MN1811 branch August 8, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spoiler doesn't render label when inside Accordion.Item
2 participants