Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select/MultiSelect with data group undefined or empty string raise each child in a list should have a unique "key" prop. #2045

Closed
AntoineGst opened this issue Aug 8, 2022 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@AntoineGst
Copy link

What package has an issue

@mantine/core

Describe the bug

When group is undefined or empty, a warning appear :

Warning: Each child in a list should have a unique "key" prop. 

What version of @mantine/hooks page do you have in package.json?

5.1

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/multiselect-with-empty-group-0gr59x

Do you know how to fix the issue

No response

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

Introduce group label and group key separately instead of group to avoid this warning.

@AntoineGst AntoineGst added the bug label Aug 8, 2022
@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed bug labels Aug 11, 2022
rtivital added a commit that referenced this issue Aug 12, 2022
…when items with group are mixed with items without groups (#2045)
@rtivital
Copy link
Member

Fixed in 5.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants