Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader is not visible if color is not specified #2047

Closed
claudious96 opened this issue Aug 8, 2022 · 2 comments
Closed

Loader is not visible if color is not specified #2047

claudious96 opened this issue Aug 8, 2022 · 2 comments

Comments

@claudious96
Copy link

claudious96 commented Aug 8, 2022

What package has an issue

@mantine/core

Describe the bug

In Mantine v 5.1.0, Loader component is not visible if the color prop is not provided, it should fallback to the theme's primary color. This affects LoadingOverlay too as it uses Loader internally. See codesandbox below for an example.

What version of @mantine/hooks page do you have in package.json?

5.1.0

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/optimistic-roentgen-191jpv?file=/src/App.tsx

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

Could be fixed by using primaryFallback: true in Loader.tsx#L58.

This possibly affected other components as there are similar changes to lines that used color || theme.primaryColor in commit c9b5e7e.

@claudious96 claudious96 added the bug label Aug 8, 2022
@rtivital
Copy link
Member

rtivital commented Aug 8, 2022

Thanks for reporting, the issue will be fixed in next patch

@rtivital
Copy link
Member

rtivital commented Aug 9, 2022

Fixed in 5.1.1

@rtivital rtivital closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants