Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 StrictMode breaks NotificationSystem #2081

Closed
josch0 opened this issue Aug 11, 2022 · 6 comments
Closed

React 18 StrictMode breaks NotificationSystem #2081

josch0 opened this issue Aug 11, 2022 · 6 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@josch0
Copy link

josch0 commented Aug 11, 2022

What package has an issue

@mantine/notifications

Describe the bug

If <React.Strict> ist used, no notifications pop up using "showNotification"

What version of @mantine/hooks page do you have in package.json?

5.1.3

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/priceless-cohen-8gj2mv

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

No response

@Geczy
Copy link

Geczy commented Aug 11, 2022

same issue but turning off react strict didn't fix it, on nextjs next.config

@amberzaragoza
Copy link

I am also experiencing the same issue.

Nadwey added a commit to Space-Eternity-3/SE3-Launcher that referenced this issue Aug 11, 2022
@TrashPandacoot
Copy link
Contributor

I'm also seeing the same thing in addition to the Modals manager also not working with with openContextModal.
v5.1.1 I'm not having the issues. Looking at the diff my only thought is it might be from the recent changes to createUseExternalEvents in the util package in this file, but I'm not sure

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Aug 12, 2022
@neolivz
Copy link

neolivz commented Aug 12, 2022

I tried and it is still broken with 5.1.3 https://github.com/neolivz/mantine-notification

@rtivital
Copy link
Member

It will be fixed in 5.1.4 patch.

@rtivital
Copy link
Member

Fixed in 5.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

6 participants