Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Stepper: Vertical stepper with multiple lines fix #2106

Merged
merged 28 commits into from Aug 14, 2022

Conversation

wes337
Copy link
Contributor

@wes337 wes337 commented Aug 13, 2022

Fixes the vertical stepper if there description has multiple lines.

Screenshots:
image

image

image

Resolves #1486

@rtivital
Copy link
Member

We have an issue that prevents lines from showing in certain stories for orientation is vertical. See "orientation" demo as reference. Can something be done about that?

Screenshot of vertical orientation in the PR:

Снимок экрана 2022-08-14 в 16 33 01

Screenshot of master branch:

Снимок экрана 2022-08-14 в 16 36 21

@wes337
Copy link
Contributor Author

wes337 commented Aug 14, 2022

Yeah, these styles are working on Firefox, but not on Chrome. Will take another look at this

@wes337
Copy link
Contributor Author

wes337 commented Aug 14, 2022

@rtivital Alright, you can check this again. Tested it on Chrome/Firefox/Edge

@rtivital rtivital merged commit b382ce7 into mantinedev:master Aug 14, 2022
@rtivital
Copy link
Member

Works great, thanks!

@wes337 wes337 deleted the MN1486-3 branch August 14, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper lines don't extend all the way when there is an expanded description
2 participants