Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced padding in SelectPopover. #2108

Closed
raymonddaikon opened this issue Aug 14, 2022 · 1 comment
Closed

Forced padding in SelectPopover. #2108

raymonddaikon opened this issue Aug 14, 2022 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@raymonddaikon
Copy link

What package has an issue

@mantine/core

Describe the bug

Impossible to change the default padding of 4px in Multiselect and Select.
Even when setting padding: !0, the dropdown in Select and Multiselect will have a 4 padding.
Not sure if this is intended behaviour but it would be nice to leave padding of the dropdown to the user.

What version of @mantine/hooks page do you have in package.json?

5.1.5

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

In SelectPopover.tsx the div on line 41 has a padding: 4 property. Unsetting this value should fix it.

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Aug 27, 2022
rtivital added a commit that referenced this issue Aug 27, 2022
@rtivital
Copy link
Member

Fixed in 5.2.4

nmay231 pushed a commit to nmay231/mantine that referenced this issue Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants