Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Dependencies Text overlap copy button #2171

Closed
vatana7 opened this issue Aug 19, 2022 · 5 comments
Closed

Install Dependencies Text overlap copy button #2171

vatana7 opened this issue Aug 19, 2022 · 5 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@vatana7
Copy link

vatana7 commented Aug 19, 2022

Link to the page where something nasty is located

https://mantine.dev/guides/next/

Exact quote of what is wrong

image

The copy button is overlapped by the text and I think we can avoid that by giving a background color to the Copy button.

Are you willing to create pull request with the fix?

Yes
@rtivital
Copy link
Member

Hi @vatana7, feel free to send a PR, I suppose we should add a background color to copy button.

@vatana7
Copy link
Author

vatana7 commented Aug 19, 2022

Will do!

@vatana7
Copy link
Author

vatana7 commented Aug 19, 2022 •
edited

May I ask where is the web repo for Mantine website? @rtivital

@rtivital
Copy link
Member

In this repository

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Aug 27, 2022
rtivital added a commit that referenced this issue Aug 27, 2022
@rtivital
[@mantine/prism] Fix copy icon interfering with code (#2171)
4c49696
@rtivital
Copy link
Member

Fixed in 5.2.4

nmay231 pushed a commit to nmay231/mantine that referenced this issue Aug 28, 2022
@rtivital @nmay231
[@mantine/prism] Fix copy icon interfering with code (mantinedev#2171)
3f3e5c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtivital @vatana7