Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version of embla-carousel-react is required in peer dependencies rather than range of versions #2200

Closed
mcmxcdev opened this issue Aug 22, 2022 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@mcmxcdev
Copy link

mcmxcdev commented Aug 22, 2022

What package has an issue

@mantine/carousel

Describe the bug

A specific version of embla-carousel-react is required here https://github.com/mantinedev/mantine/blob/master/src/mantine-carousel/package.json#L27

Projects with strict peer dependencies setting will fail once embla-carousel-react version diverges.

It would be better to allow ^ so that patch and minor versions can be used. (There is an important 7.0.1 release since a couple of days)

What version of @mantine/hooks page do you have in package.json?

5.1.6

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

No response

@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed review required labels Aug 22, 2022
nmay231 pushed a commit to nmay231/mantine that referenced this issue Aug 22, 2022
@rtivital
Copy link
Member

fixed in 5.2.3

nmay231 pushed a commit to nmay231/mantine that referenced this issue Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants