Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Drawer: withOverlay={false} should let you click-through #2351

Merged

Conversation

italodeandra
Copy link
Contributor

@italodeandra italodeandra commented Sep 4, 2022

No description provided.

@italodeandra italodeandra changed the title add click-through capability to overlay [@mantine/core] Overlay: add click-through capability Sep 4, 2022
@rtivital
Copy link
Member

rtivital commented Sep 5, 2022

Hi @italodeandra, we do not need separate prop for that, if withOverlay is set to false, then it should allow click thought.

@italodeandra
Copy link
Contributor Author

italodeandra commented Sep 5, 2022

Hey @rtivital,

I also thought that, but it only removes the overlay styles. To be able to click through, I still need to do this:

<Drawer
  opened={opened}
  onClose={handleDrawerClose}
  title="Filme"
  padding="xl"
  size="xl"
  position="right"
  withOverlay={false}
  sx={{
    pointerEvents: "none",
    "& > *": {
      pointerEvents: "auto",
    },
  }}
>

So perhaps I should remove the clickThrough from the Overlay and just keep overlayClickThrough on the Drawer?

@rtivital
Copy link
Member

rtivital commented Sep 5, 2022

Check if withOverlay={false} and add those styles on library level, there is no need for extra prop for that.

@italodeandra
Copy link
Contributor Author

Check if withOverlay={false} and add those styles on library level, there is no need for extra prop for that.

Done.

@italodeandra italodeandra changed the title [@mantine/core] Overlay: add click-through capability [@mantine/core] Drawer: withOverlay={false} should let you click-through Sep 5, 2022
@rtivital rtivital merged commit cd546df into mantinedev:master Sep 6, 2022
@rtivital
Copy link
Member

rtivital commented Sep 6, 2022

Thanks!

@ashishsurya
Copy link

ashishsurya commented Jan 17, 2024

I dont think this works

@heejj1206
Copy link

heejj1206 commented Mar 20, 2024

@rtivital @italodeandra I don't think it's solved

@italodeandra
Copy link
Contributor Author

Hey bros, my changes were removed by another PR a couple years ago. I don't use the lib anymore so I think you should create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants