Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel.Item doesn't have spacing between other items #2396

Closed
danestves opened this issue Sep 8, 2022 · 5 comments
Closed

Carousel.Item doesn't have spacing between other items #2396

danestves opened this issue Sep 8, 2022 · 5 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@danestves
Copy link

What package has an issue

@mantine/core

Describe the bug

From the 5.2.7 release that introduce this fix #2336 now the items doesn't have any spacing between

CleanShot 2022-09-08 at 12 30 47

What version of @mantine/hooks page do you have in package.json?

5.2.7

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

No response

@rtivital
Copy link
Member

rtivital commented Sep 8, 2022

Thanks for reporting, the issue will be fixed in next patch

@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed review required labels Sep 8, 2022
@danestves
Copy link
Author

Thank you! I'm still new with the core code of Mantine, hope in a future be available to understand and make features and fixes for the library :D

@italodeandra
Copy link
Contributor

@rtivital Did you already found the problem? This problem seems weird. If you didn't investigate yet I will.

@rtivital
Copy link
Member

rtivital commented Sep 9, 2022

Yes, it is caused by the change in PR, you can check out the same issue here in final slide – https://mantine.dev/others/carousel/#size-and-gap

I've reverted your PR for now

@rtivital
Copy link
Member

rtivital commented Sep 9, 2022

Fixed in 5.3.0

@rtivital rtivital closed this as completed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

3 participants