Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @mantine/rte dependency of react-quill to 2.0.0 from the beta 4, 2.0.0-beta.4 #2449

Closed
AddictArts opened this issue Sep 14, 2022 · 1 comment

Comments

@AddictArts
Copy link

What package has an issue

@mantine/rte

Describe the bug

The beta version of react-quill has peerDependencies for react and react-dom ^16 || ^17. This can result in a local npm install using react 18 failing. This creates confusion especially in a npm workspaces configuration. Version 2.0.0 of react-quill adds ^18, which would eliminate any Mantine running into installation fails and runtime react-dom/client import fails.

What version of @mantine/hooks page do you have in package.json?

5.3.1

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

Change the @mantine/rte dependency to 2.0.0 from 2.0.0-beta.4.

@AddictArts AddictArts changed the title Update @mantine/rte dependency of react-quill to 2.0.0 fromt the last beta Update @mantine/rte dependency of react-quill to 2.0.0 from the beta 4, 2.0.0-beta.4 Sep 14, 2022
rtivital added a commit that referenced this issue Sep 15, 2022
@rtivital
Copy link
Member

Fixed in 5.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants