Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] PasswordInput: fix selected text style #2473

Merged
merged 2 commits into from Sep 16, 2022

Conversation

lawff
Copy link
Contributor

@lawff lawff commented Sep 16, 2022

#2468, just modify the height to bigger than the line-height

@rtivital
Copy link
Member

Hi @lawff, this change makes input content misaligned vertically
Снимок экрана 2022-09-16 в 17 05 45

@rickmoens
Copy link

Adding vertical-align: middle to the input seems to fix it.

@lawff
Copy link
Contributor Author

lawff commented Sep 16, 2022

Hi @lawff, this change makes input content misaligned vertically Снимок экрана 2022-09-16 в 17 05 45

sorry, I made a mistake. Now, I add the border to the inner input to solve the misaligned vertically, I need your advice if this solution is helpful.

@rtivital rtivital merged commit 993212a into mantinedev:master Sep 16, 2022
@rtivital
Copy link
Member

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants