Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit by default params in List.Item from List #2495

Closed
7iomka opened this issue Sep 19, 2022 · 3 comments
Closed

Inherit by default params in List.Item from List #2495

7iomka opened this issue Sep 19, 2022 · 3 comments

Comments

@7iomka
Copy link
Contributor

7iomka commented Sep 19, 2022

What package has an issue

@mantine/core

Describe the bug

For now how I see all params available on ListStylesParams is not inherited on List.Item by default.
This behavior produce impossible to check params on List when you trying to configure it on Provider level.
For example I tried to fix by myself this issue
See the demo link, open console and you will see.

What version of @mantine/hooks page do you have in package.json?

latest

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/currying-violet-hnkvx0?file=/src/App.tsx

Do you know how to fix the issue

No response

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

Separate configuration for List and ListItem or inherit params passed in List unless they are overridden

@rtivital
Copy link
Member

rtivital commented Oct 4, 2022

Sandbox works correctly with 5.5.2 – https://codesandbox.io/s/thirsty-pare-hkwgsy?file=/src/App.tsx

@rtivital rtivital closed this as completed Oct 4, 2022
@7iomka
Copy link
Contributor Author

7iomka commented Oct 4, 2022

Sandbox works correctly with 5.5.2 – https://codesandbox.io/s/thirsty-pare-hkwgsy?file=/src/App.tsx

What you mean it works correctly?
Is there same problem
image

listStyleType is undefined on Item logs

@rtivital
Copy link
Member

rtivital commented Nov 2, 2022

@rtivital rtivital closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants