Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] FloatingArrow: fix Arrow postion #2521

Merged
merged 4 commits into from Sep 24, 2022

Conversation

lawff
Copy link
Contributor

@lawff lawff commented Sep 21, 2022

@rtivital
Copy link
Member

Hi @lawff please make sure that:

  • Popover component has these changes as well
  • floating ui package is updated to the latest version
  • you've included stories that can be used for testing Tooltip and Popover components

@lawff
Copy link
Contributor Author

lawff commented Sep 22, 2022

Hi @lawff please make sure that:

  • Popover component has these changes as well
  • floating ui package is updated to the latest version
  • you've included stories that can be used for testing Tooltip and Popover components

yes, now I

  • add the stories in both the Tooltip and Popover components.

  • Update the floating UI package to the latest

@rtivital rtivital merged commit 067eca1 into mantinedev:master Sep 24, 2022
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants