Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] Fix indentation on List (listStylePosition: 'inside') #2606

Merged
merged 2 commits into from Oct 3, 2022
Merged

[@mantine/core] Fix indentation on List (listStylePosition: 'inside') #2606

merged 2 commits into from Oct 3, 2022

Conversation

7iomka
Copy link
Contributor

@7iomka 7iomka commented Oct 2, 2022

Revert #2528
Closes #2494

@rtivital rtivital merged commit 6c8a8b1 into mantinedev:master Oct 3, 2022
@rtivital
Copy link
Member

rtivital commented Oct 3, 2022

Thanks!

@vrtischev
Copy link

vrtischev commented Oct 4, 2022 •
edited

@7iomka, I'll have to revert it, unless you send a PR with a fix, the PR broke the component – https://mantine.dev/core/list/#with-icons

@7iomka
Copy link
Contributor Author

7iomka commented Oct 4, 2022

@7iomka, I'll have to revert it, unless you send a PR with a fix, the PR broke the component – https://mantine.dev/core/list/#with-icons

Nope, I'll fix now

@7iomka 7iomka mentioned this pull request Oct 4, 2022
Merged
@7iomka
Copy link
Contributor Author

7iomka commented Oct 4, 2022

@rtivital #2624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep the indentation with multiline contents of Item in List
3 participants
@7iomka @rtivital @vrtischev