[@mantine/core] Menu - Close menu when menu target children change #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtivital
reviewed
Oct 6, 2022
wes337
changed the title
rtivital
reviewed
Oct 6, 2022
|
Thanks! |
wes337
added a commit
to wes337/mantine
that referenced
this pull request
Oct 13, 2022
rtivital
pushed a commit
that referenced
this pull request
Oct 22, 2022
…n step is larger than the difference between current value and min/max (#2656) * [@mantine/core] Select: only use open/close callback when value changes * [@mantine/core] Select: do not use early return * [@mantine/core] Slider: fix numeric max and negative numbers * [@mantine/core] Slider: return min val is value is min * [@mantine/core] Menu - revert PR #2646 * [@mantine/core] Slider: dont return value lower than min or greater than max
rtivital
pushed a commit
that referenced
this pull request
Nov 2, 2022
* [@mantine/core] Select: only use open/close callback when value changes * [@mantine/core] Select: do not use early return * [@mantine/core] Menu - revert PR #2646 * [Mantine/core] Slider: fix min/max values * [@mantine/core] Slider: remove unneeded story * [@mantine/core] Slider: revert changes to minmax story
rtivital
pushed a commit
that referenced
this pull request
Feb 3, 2023
… MultiSelect and Autocomplete dropdown was flipped and user started searching (#3439) * [@mantine/core] Select: only use open/close callback when value changes * [@mantine/core] Select: do not use early return * [@mantine/core] Menu - revert PR #2646 * [@mantine/core] recalculate dropdown position on search input change * [@mantine/core] recalculate dropdown position on search input change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close the Menu when menu target's children change.
When the menu target is unmounted:
When the menu target is hidden:
Resolves #2535