Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Slider: Show correct numeric values #2656

Merged
merged 37 commits into from Oct 22, 2022

Conversation

wes337
Copy link
Contributor

@wes337 wes337 commented Oct 7, 2022

The slider will now show the correct min/max numeric values.

Before

image

After

image

And if the min is a negative value:
slider-negative

Resolves #2444

@rtivital
Copy link
Member

It does now work correctly in the storybook – min is set to 1, but the user will still be able to go to 0

2022-10-11.18.00.22.mov

@rtivital
Copy link
Member

@wes337 Are you planning to finish the work on this PR?

@wes337
Copy link
Contributor Author

wes337 commented Oct 18, 2022

@wes337 Are you planning to finish the work on this PR?

Yes, I want to finish this. Sorry I’ve been a bad contributor lately — been busy with work.

@rtivital
Copy link
Member

No worries, just checking that you haven't forgotten about it

@wes337
Copy link
Contributor Author

wes337 commented Oct 19, 2022

@rtivital This can be reviewed again

@rtivital rtivital merged commit c2650b7 into mantinedev:master Oct 22, 2022
@rtivital
Copy link
Member

Thanks!

@rtivital
Copy link
Member

@wes337 this PR broke something:

Can you have a look?

@wes337
Copy link
Contributor Author

wes337 commented Oct 28, 2022

@wes337 this PR broke something:

Can you have a look?

Yes, I’ll look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider not showing correct values
2 participants