Fix useScrollIntoView ignoring parameter changes #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, useScrollIntoView returns a memoized callback that always
refers to the params passed during the first render of the calling
component, so calling with dynamically computed params, e.g.
useScrollIntoView({ offset: someVariable }) will memoize the offset
passed during the first render. If the component re-renders, any new
offset passed is ignored.
Aditionally, 'scrollableRef.current' is an invalid dependency, see
https://epicreact.dev/why-you-shouldnt-put-refs-in-a-dependency-array/
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, useScrollIntoView returns a memoized callback that always refers to the params passed during the first render of the calling component, so calling with dynamically computed params, e.g. useScrollIntoView({ offset: someVariable }) will memoize the offset passed during the first render. If the component re-renders, any new offset passed is ignored.
Aditionally, 'scrollableRef.current' is an invalid dependency, see https://epicreact.dev/why-you-shouldnt-put-refs-in-a-dependency-array/