Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination issue #2979

Closed
kulame opened this issue Nov 16, 2022 · 2 comments
Closed

Pagination issue #2979

kulame opened this issue Nov 16, 2022 · 2 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@kulame
Copy link

kulame commented Nov 16, 2022

What package has an issue

@mantine/core

Describe the bug

when i try to use mantine Pagnation component.

A%Q8QUYNZJU(I@51K4HHTBM

i got the page "391.7" string type value.

I expected it should be a number type 391

What version of @mantine/hooks page do you have in package.json?

5.6.3

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

No response

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

No response

@zhulien-ivanov
Copy link
Contributor

zhulien-ivanov commented Nov 16, 2022

Well, you have provided 391.7 to total. Even thought that this potentially should be covered on component level, it is something you SHOULD definitely take care of yourself before passing to the component. Use Math.trunc(<total>) and then pass it to Pagination.

@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed review required labels Nov 17, 2022
rtivital added a commit that referenced this issue Nov 17, 2022
@rtivital
Copy link
Member

Fixed in 5.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

3 participants