[@mantine/form] useForm: fix isDirty for list fields #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft, will try to retain |
gdostie
force-pushed
the
dirty-state-simplification
branch
3 times, most recently
from
5f83932
to
0d7bf6a
Compare
|
I managed to retain I renamed them in the code as "manual overrides" of the standard dirty behaviour. Reopening for review. |
Simplify the dirty state functionalities by computing the isDirty only on demand using deep comparison of values. Manually managing a dirty state parallel to the values state was very much bug prone.
gdostie
force-pushed
the
dirty-state-simplification
branch
from
0d7bf6a
to
bf76ebb
Compare
gdostie
changed the title
rtivital
reviewed
Nov 23, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By computing the isDirty only on demand using deep comparison of the
valuesstate, it removes many bugs related toisDirtyand nested fields. Manually managing a dirty state parallel to the values state was very much bug prone, considering all the possible updates to form values that can occur.Disclaimer: by doing this we loose 2 functionalitiesFixed ✅initialDirtyandsetDirty. IMHO the pros outweighs the cons, but I am curious to see what the community thinks.Fixes: #3001 and #2937