Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Drawer: Add id for aria- attributes #3027

Merged
merged 1 commit into from Nov 23, 2022
Merged

[@mantine/core] Drawer: Add id for aria- attributes #3027

merged 1 commit into from Nov 23, 2022

Conversation

noahsb
Copy link
Contributor

@noahsb noahsb commented Nov 22, 2022

As per discussion, added id to Drawer to allow aria- attributes on title and body of Drawer.

Unlike Modal, I did not apply the baseId directly, but use it only for generating titleId and bodyId. This now passes an axe DevTools scan

Added a test to check that passing id gets sent to title and body of Drawer

@rtivital rtivital merged commit 51a0299 into mantinedev:dev Nov 23, 2022
@rtivital
Copy link
Member

Thanks!

@noahsb noahsb deleted the drawer-a11y branch November 23, 2022 06:44
@ivanbrykov
Copy link

ivanbrykov commented Nov 28, 2022

@noahsb so now you have introduced a new level of DOM hierarchy in Drawer that has id but no class name and is not accessible via styles API. It literally breaks my UI. And there is no non-hacky way to fix it. Can you please consider adding styles API to this new container

cc: @rtivital

@noahsb
Copy link
Contributor Author

noahsb commented Nov 28, 2022

Could you please move this to an issue and provide a working example, @brykov? I see value in adding an additional styles API to the new container but this discussion shouldn't be inside a merged PR without an example.

Edit: A quick search of the current issues shows #3056 and the relevant open PR for it #3061...

@ivanbrykov
Copy link

Edit: A quick search of the current issues shows #3056 and the relevant open PR for it #3061...

Yes, that sounds about right. It says it's already been released. I'll check.

@noahsb noahsb mentioned this pull request Nov 30, 2022
rtivital pushed a commit that referenced this pull request Nov 30, 2022
Describe new aria-* attribute support from #3027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants