[@mantine/core] always try centering arrow on target for popover #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdsande
force-pushed
the
feat/popover-arrow-positioning
branch
from
d15e5bd
to
a80de1f
Compare
jvdsande
commented
Nov 26, 2022
| import { getArrowPositionStyles } from './get-arrow-position-styles'; | ||
| import { FloatingPosition } from '../types'; | ||
|
|
||
| interface FloatingArrowProps extends React.ComponentPropsWithoutRef<'div'> { | ||
| withBorder: boolean; | ||
| position: FloatingPosition; | ||
| arrowSize: number; | ||
| arrowOffset: number; |
There was a problem hiding this comment.
We don't need the arrow offset anymore in this component, as the offset is now used as a configuration for the arrow middleware of floating UI directly.
| }, | ||
| ref | ||
| ) => { | ||
| const theme = useMantineTheme(); |
There was a problem hiding this comment.
We don't need the theme at all anymore since the RTL direction is already handled by Floating UI
| } | ||
|
|
||
| return {}; | ||
| } |
There was a problem hiding this comment.
Those two functions are not needed anymore, as position is correctly handled by Floating UI, including RTL. So we can directly set left for vertical and top for horizontal sides
| top: arrowPosition, | ||
| borderBottom: 0, | ||
| [dir === 'ltr' ? 'borderRight' : 'borderLeft']: 0, |
There was a problem hiding this comment.
This check was actually messing things up for RTL, simply removing it fixes things
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix some outstanding issues introduced with the switch to Floating UI:
-endor `-start``-endand-startplacement now only impact the dropdown, not the arrow. The arrow will always try to align itself on the center of the target.arrowOffsetnow acts as a min distance from dropdown border, rather than a fixed position in-endand-startplacement.