[@mantine/tiptap]: add forward ref to mantine tip tap editor #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adarshaacharya
commented
Nov 27, 2022
adarshaacharya
commented
- forward ref to avoid ref warning in mantine tip tap editor
rtivital
reviewed
Nov 27, 2022
| @@ -50,7 +50,7 @@ const defaultProps: Partial<RichTextEditorProps> = { | |||
| withTypographyStyles: true, | |||
| }; | |||
|
|
|||
| export function RichTextEditor(props: RichTextEditorProps) { | |||
| export const RichTextEditor = forwardRef<HTMLInputElement, RichTextEditorProps>((props, ref) => { | |||
There was a problem hiding this comment.
ref type is incorrect, it is div element, not input
There was a problem hiding this comment.
corrected, thanks
adarshaacharya
force-pushed
the
feature/tiptap-ref
branch
from
8d54559
to
6986cb5
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.