Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Select: fixed the display of values in the dropdown i… #3070

Merged

Conversation

cheechoo28
Copy link
Contributor

Issue example: https://codesandbox.io/s/serverless-framework-kl3vu3?file=/src/App.tsx
Issue description:
When I added a prop limit, after selecting the value, the dropdown is closed and if it is opened again, all values are displayed ignoring the limit.

@rtivital
Copy link
Member

rtivital commented Nov 28, 2022

@cheechoo28 it does not seem to work correctly, see example with limit={2}, there should always be 2 options if they are available in the data

2022-11-28.14.29.16.mov

@cheechoo28
Copy link
Contributor Author

@rtivital That's what I intended. The idea is that two things are always shown in the dropdown . If nothing is selected, the first 3 are shown. If you have selected something, closed the dropdown and reopened, the first selected and subsequent ones are shown.

@rtivital
Copy link
Member

Nope, this is not the correct logic that will create a lot of confusion

@cheechoo28
Copy link
Contributor Author

@rtivital Well, I'll think about this problem again. I think the way it works now is also a confusion. I set the limit , but after I selected the value and reopened the dropdown , all the items are shown again

@rtivital
Copy link
Member

Yes, currently it works incorrectly as well. I've described how it should work in the comment with the video.

@cheechoo28
Copy link
Contributor Author

@rtivital should now work correctly

@rtivital rtivital merged commit f729437 into mantinedev:master Dec 4, 2022
@rtivital
Copy link
Member

rtivital commented Dec 4, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants