[@mantine/core] add a prop to choose how to position floating arrow #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a
arrowPosition?: 'side' | 'center'prop to Tooltip and Popover (and components inheriting from Popover).'side'is the previous behavior, where arrow sticks to the side of the tooltip inendandstartposition, but it not correctly placed when the dropdown is shifted to stay in the viewport.'center'is the newer behavior, where arrow tries to center itself to the target, but ends up aligned to the "wrong" side if the tooltip is smaller than the target.