[@mantine/form] fix type inference of validation for union types #3101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union types were incorrectly distributed when computing validation functions. This was not visible for the most classic unions, those including
undefined
andnull
, because Mantine's codebase is not in strict mode.In strict mode, if the type of a value includes
null
orundefined
in a union, it will get incorrectly distributed, asundefined
andnull
will be inferred independently.To avoid that, I wrap the
Value
inferred type intoNonNullable
before checking it against Array and Record cases. This prevents early distribution of theValue
inferred type since the check is not directly against it.It is safe since
NonNullable
will get rid ofundefined
andnull
, which would be "false" in those checks anyway (not an Array, not a Record), so the comparison is still correct.